Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update video recorder tutorial screenshot #2135

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 11, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#396

Summary

Updates screenshot and text describing the screenshot

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 11, 2023
Signed-off-by: Ian Chen <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get a screenshot without the cutoff reset button?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep done, 61348da

Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #2135 (1ba63f7) into gz-sim7 (183c04f) will increase coverage by 0.01%.
Report is 1 commits behind head on gz-sim7.
The diff coverage is 100.00%.

❗ Current head 1ba63f7 differs from pull request most recent head 61348da. Consider uploading reports for the commit 61348da to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #2135      +/-   ##
===========================================
+ Coverage    65.01%   65.02%   +0.01%     
===========================================
  Files          356      356              
  Lines        28929    28932       +3     
===========================================
+ Hits         18808    18814       +6     
+ Misses       10121    10118       -3     
Files Changed Coverage Δ
...int_position_controller/JointPositionController.cc 59.09% <100.00%> (+3.02%) ⬆️

... and 1 file with indirect coverage changes

@mjcarroll mjcarroll merged commit 9d79b62 into gz-sim7 Sep 12, 2023
@mjcarroll mjcarroll deleted the video_recorder_tutorial branch September 12, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz-sim: Video Recorder
2 participants