Skip to content

TouchPlugin: Reset the plugin with the initial values #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 8, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#387

Summary

When a TouchPlugin is resetted the initial state was not working properly, this PR should fix the issue

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from mjcarroll as a code owner September 8, 2023 14:48
@ahcorde ahcorde self-assigned this Sep 8, 2023
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 8, 2023
@ahcorde ahcorde marked this pull request as draft September 8, 2023 14:56
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde marked this pull request as ready for review September 8, 2023 15:14
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2132 (2d317d0) into gz-sim8 (923ccee) will decrease coverage by 0.01%.
Report is 13 commits behind head on gz-sim8.
The diff coverage is 62.50%.

❗ Current head 2d317d0 differs from pull request most recent head e8a3cd1. Consider uploading reports for the commit e8a3cd1 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim8    #2132      +/-   ##
===========================================
- Coverage    65.45%   65.44%   -0.01%     
===========================================
  Files          323      323              
  Lines        30704    30707       +3     
===========================================
  Hits         20097    20097              
- Misses       10607    10610       +3     
Files Changed Coverage Δ
src/systems/touch_plugin/TouchPlugin.hh 100.00% <ø> (ø)
src/systems/touch_plugin/TouchPlugin.cc 86.30% <62.50%> (-1.82%) ⬇️

@azeey azeey added the beta Targeting beta release of upcoming collection label Sep 13, 2023
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@azeey azeey merged commit 2e58d61 into gz-sim8 Sep 27, 2023
@azeey azeey deleted the ahcorde/8/touch_plugin_reset branch September 27, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants