Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thrust cmd topic in underwater tutorial #2120

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix thrust cmd topic in underwater tutorial #2120

merged 1 commit into from
Sep 6, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 5, 2023

🦟 Bug fix

Summary

Fixes thrust cmd topic name as found in gazebosim/gazebo_test_cases#393

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mabelzhang as a code owner September 5, 2023 21:11
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #2120 (f052167) into gz-sim7 (5ebf860) will decrease coverage by 0.01%.
Report is 1 commits behind head on gz-sim7.
The diff coverage is n/a.

❗ Current head f052167 differs from pull request most recent head 54f8946. Consider uploading reports for the commit 54f8946 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #2120      +/-   ##
===========================================
- Coverage    65.01%   65.01%   -0.01%     
===========================================
  Files          356      356              
  Lines        28929    28929              
===========================================
- Hits         18808    18807       -1     
- Misses       10121    10122       +1     

see 1 file with indirect coverage changes

@iche033 iche033 merged commit 5bb1b1c into gz-sim7 Sep 6, 2023
@iche033 iche033 deleted the cmd_thrust branch September 6, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants