Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default topic name of JointStatePublisher #2115

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

Bi0T1N
Copy link
Contributor

@Bi0T1N Bi0T1N commented Sep 1, 2023

🦟 Bug fix

Summary

The default topic name is specified as /joint_state in JointStatePublisher.cc

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

the default topic name is specified as /joint_state
in JointStatePublisher.cc

Signed-off-by: Bi0T1N <[email protected]>
@Bi0T1N Bi0T1N requested a review from mjcarroll as a code owner September 1, 2023 21:57
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 1, 2023
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just minor lint issue

Signed-off-by: Bi0T1N <[email protected]>
@iche033 iche033 merged commit 5ebf860 into gazebosim:gz-sim7 Sep 5, 2023
@Bi0T1N Bi0T1N deleted the topicname_jsp branch December 21, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants