Skip to content

Prevent printing misleading error msg in visualize lidar gui plugin #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 15, 2023

🦟 Bug fix

Prevents the following msg from being printed when the scene and plugin are loaded on startup:

[GUI] [Err] [VisualizeLidar.cc:252] Lidar pointer is not set

Related question:
https://robotics.stackexchange.com/questions/25151/gazebo-garden-gui-err-visualizelidar-cc251-lidar-pointer-is-not-set

Summary

Currently we don't create the lidar visual if the scene does not have any visuals (happens on startup). As the result, in the first render event, the error msg is printed. This does not need to be the case. It is safe to create the lidar visual even if the scene is empty.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner August 15, 2023 18:15
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2077 (3398cba) into gz-sim7 (579013f) will not change coverage.
The diff coverage is n/a.

❗ Current head 3398cba differs from pull request most recent head de852dc. Consider uploading reports for the commit de852dc to get more accurate results

@@           Coverage Diff            @@
##           gz-sim7    #2077   +/-   ##
========================================
  Coverage    65.09%   65.09%           
========================================
  Files          354      354           
  Lines        28732    28732           
========================================
  Hits         18702    18702           
  Misses       10030    10030           

@mjcarroll mjcarroll merged commit 8352d3d into gz-sim7 Aug 15, 2023
@mjcarroll mjcarroll deleted the visualize_lidar_msg branch August 15, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants