Prevent printing misleading error msg in visualize lidar gui plugin #2077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Prevents the following msg from being printed when the scene and plugin are loaded on startup:
Related question:
https://robotics.stackexchange.com/questions/25151/gazebo-garden-gui-err-visualizelidar-cc251-lidar-pointer-is-not-set
Summary
Currently we don't create the lidar visual if the scene does not have any visuals (happens on startup). As the result, in the first render event, the error msg is printed. This does not need to be the case. It is safe to create the lidar visual even if the scene is empty.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.