Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sdf::Element::FindElement instead of GetElement in ApplyLinkWrench #2052

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jul 26, 2023

🦟 Bug fix

Fixes #

Summary

I noticed the error

Error [Utils.cc:174] Missing element description for [persistent]

when testing #2014. /cc @Henrique-BO

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This fixes errors such as
```
Error [Utils.cc:174] Missing element description for [persistent]
```

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from mjcarroll as a code owner July 26, 2023 19:12
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 26, 2023
@azeey azeey merged commit 4587827 into gazebosim:ign-gazebo3 Jul 31, 2023
@azeey azeey deleted the use_find_element branch July 31, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants