Skip to content

Change type of Component::typeName and address outstanding todos #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jul 26, 2023

Summary

The type is changed from std::string to const char * to prevent the static initialization order fiasco. This PR also deprecates Factory::Register functions that don't include the ID of the entity that wants to register the component.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from mjcarroll as a code owner July 26, 2023 03:09
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #2049 (a965e70) into main (dbebc39) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a965e70 differs from pull request most recent head 17fd401. Consider uploading reports for the commit 17fd401 to get more accurate results

@@            Coverage Diff             @@
##             main    #2049      +/-   ##
==========================================
+ Coverage   65.45%   65.47%   +0.01%     
==========================================
  Files         312      312              
  Lines       29808    29810       +2     
==========================================
+ Hits        19510    19517       +7     
+ Misses      10298    10293       -5     
Files Changed Coverage Δ
include/gz/sim/components/Component.hh 100.00% <ø> (ø)
include/gz/sim/components/Factory.hh 97.29% <100.00%> (+0.02%) ⬆️
src/ComponentFactory.cc 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@azeey
Copy link
Contributor Author

azeey commented Jul 27, 2023

I believe all the test failures existed before this PR. Merging!

@azeey azeey merged commit aa173ae into gazebosim:main Jul 27, 2023
@azeey azeey deleted the comp_factory_todos branch July 27, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants