Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds python demo examples #2044

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Conversation

Voldivh
Copy link
Contributor

@Voldivh Voldivh commented Jul 20, 2023

🎉 New feature

Summary

This PR creates the python version of a couple of examples. It is basically the same code as the C++ version but using the python bindings for gz-transport package created on this PR.

Test it

The run instructions appears as comments at the top of each file.
Note: In order for this to work it is needed to checkout the branch from the PR mentioned above.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Voldivh Voldivh requested a review from mjcarroll as a code owner July 20, 2023 19:56
@Voldivh Voldivh requested a review from azeey July 20, 2023 19:56
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 20, 2023
@Voldivh
Copy link
Contributor Author

Voldivh commented Jul 20, 2023

@azeey For some reason it didn't allow me to reopen the other PR, so I went ahead and created this one.

@Voldivh Voldivh mentioned this pull request Jul 20, 2023
9 tasks
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #2044 (b04d3c4) into main (5846393) will decrease coverage by 0.04%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

❗ Current head b04d3c4 differs from pull request most recent head 335cf36. Consider uploading reports for the commit 335cf36 to get more accurate results

@@            Coverage Diff             @@
##             main    #2044      +/-   ##
==========================================
- Coverage   65.32%   65.28%   -0.04%     
==========================================
  Files         321      321              
  Lines       30303    30303              
==========================================
- Hits        19795    19783      -12     
- Misses      10508    10520      +12     

see 1 file with indirect coverage changes

@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@azeey azeey requested a review from caguero August 21, 2023 18:28
@azeey
Copy link
Contributor

azeey commented Aug 28, 2023

@caguero mind taking a look?

Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both examples work for me. I just left a few minor comments.

Signed-off-by: Voldivh <[email protected]>
@azeey azeey dismissed caguero’s stale review August 31, 2023 03:17

Feedback addressed

@azeey azeey merged commit 92158db into gazebosim:main Aug 31, 2023
@Voldivh Voldivh deleted the voldivh/add_python_demo branch August 31, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants