-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds python demo examples #2044
Conversation
Signed-off-by: Voldivh <[email protected]>
@azeey For some reason it didn't allow me to reopen the other PR, so I went ahead and created this one. |
Codecov Report
@@ Coverage Diff @@
## main #2044 +/- ##
==========================================
- Coverage 65.32% 65.28% -0.04%
==========================================
Files 321 321
Lines 30303 30303
==========================================
- Hits 19795 19783 -12
- Misses 10508 10520 +12 |
@caguero mind taking a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both examples work for me. I just left a few minor comments.
Signed-off-by: Voldivh <[email protected]>
🎉 New feature
Summary
This PR creates the python version of a couple of examples. It is basically the same code as the C++ version but using the python bindings for
gz-transport
package created on this PR.Test it
The run instructions appears as comments at the top of each file.
Note: In order for this to work it is needed to checkout the branch from the PR mentioned above.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.