-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unload render engine when the sensors system exits #1960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
mjcarroll
reviewed
Apr 7, 2023
Signed-off-by: Ian Chen <[email protected]>
This was referenced Apr 13, 2023
Codecov Report
@@ Coverage Diff @@
## gz-sim7 #1960 +/- ##
===========================================
- Coverage 65.08% 65.02% -0.07%
===========================================
Files 352 352
Lines 28312 28393 +81
===========================================
+ Hits 18428 18463 +35
- Misses 9884 9930 +46
|
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
8 tasks
mjcarroll
approved these changes
Apr 25, 2023
I think this is still failing |
Signed-off-by: Ian Chen <[email protected]>
removed bad |
ubuntu build fixed |
mjcarroll
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #1410
Depends on:
Summary
The render engine is never destroyed / unloaded when the server shuts down. This leads to issues such as memory leak and not being able to relaunch the server with the sensors system, e.g. as seen in #1410, rendering tests n gz-sim can not be run one after another in the same process.
This PR adds a function in RenderUtil to destroy the scene and unload the engine.
To test:
Run the
PERFORMANCE_sensors_system
test that repeatedly launches the server with the sensors system.Note that to run the tests, you'll need the above PRs in gz-rendering and gz-sensors otherwise gz will crash.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.