-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actuators message for JointPositionController. #1954
Actuators message for JointPositionController. #1954
Conversation
Allows for position control of joints with actuators msg. Signed-off-by: Benjamin Perseghetti <[email protected]>
Still needs the tests added. |
Codecov Report
@@ Coverage Diff @@
## gz-sim7 #1954 +/- ##
===========================================
+ Coverage 64.62% 64.98% +0.36%
===========================================
Files 348 352 +4
Lines 27859 28395 +536
===========================================
+ Hits 18004 18453 +449
- Misses 9855 9942 +87
|
Signed-off-by: Benjamin Perseghetti <[email protected]>
@azeey @mjcarroll good to merge now? |
src/systems/joint_position_controller/JointPositionController.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Benjamin Perseghetti <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
@mjcarroll I updated what you requested. I also force pushed the same changes to JC PR #1953 As well as fixed Ackermann and unified MulticopterMotorModel with a deprecation warning and ability to use same |
🎉 New feature
Adds ability to control the position of joints with the position field of the actuators message.
Closes: #1974
As seen in the Gazebo community meeting:
https://vimeo.com/812911652#t=39m58s
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.