Use a queue to track component registration from mulitiple sources #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azeey
force-pushed
the
fix_comp_registration
branch
from
7b94729 to
e190c51
Compare
Signed-off-by: Addisu Z. Taddese <[email protected]>
azeey
force-pushed
the
fix_comp_registration
branch
from
e190c51 to
10e1174
Compare
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1836 +/- ##
===============================================
+ Coverage 64.80% 64.83% +0.02%
===============================================
Files 322 323 +1
Lines 26391 26416 +25
===============================================
+ Hits 17104 17127 +23
- Misses 9287 9289 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
7 tasks
mjcarroll
reviewed
Jan 26, 2023
mjcarroll
approved these changes
Jan 26, 2023
Signed-off-by: Addisu Z. Taddese <[email protected]>
mjcarroll
approved these changes
Feb 8, 2023
|
Building on Ubuntu one more time to see if the |
8 tasks
|
|
7 tasks
|
@osrf-jenkins run tests please |
This was referenced Mar 16, 2023
azeey
added a commit
to azeey/gz-sim
that referenced
this pull request
Mar 21, 2023
…azebosim#1836) When a plugin gets unloaded, the component types it registered will have invalid component descriptors. Attempting to create new components of those types will result in a segfault. This PR is an attempt to fix that by keeping track of all component registrations and removing invalid ones when plugins get unloaded. --------- Signed-off-by: Addisu Z. Taddese <[email protected]>
8 tasks
Merged
azeey
added a commit
that referenced
this pull request
Mar 30, 2023
…1836) When a plugin gets unloaded, the component types it registered will have invalid component descriptors. Attempting to create new components of those types will result in a segfault. This PR is an attempt to fix that by keeping track of all component registrations and removing invalid ones when plugins get unloaded. --------- Signed-off-by: Addisu Z. Taddese <[email protected]>
8 tasks
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #1780, #806
Summary
When a plugin gets unloaded, the component types it registered will have invalid component descriptors. Attempting to create new components of those types will result in a segfault. This PR is an attempt to fix that by keeping track all component registrations and removing invalid ones when plugins get unloaded.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.