Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Fortress tests related to lights #1827

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 1, 2022

Signed-off-by: Alejandro Hernández Cordero [email protected]

🦟 Bug fix

Fixes #

Summary

Ligths are now adding a visual entity, This new change requires to update tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from mjcarroll as a code owner December 1, 2022 14:46
@ahcorde ahcorde self-assigned this Dec 1, 2022
@ahcorde ahcorde mentioned this pull request Dec 1, 2022
8 tasks
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Dec 1, 2022
@ahcorde ahcorde requested a review from Crola1702 December 1, 2022 14:46
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #1827 (ac9eaa2) into ign-gazebo6 (216d5a5) will increase coverage by 0.15%.
The diff coverage is 90.69%.

@@               Coverage Diff               @@
##           ign-gazebo6    #1827      +/-   ##
===============================================
+ Coverage        64.60%   64.75%   +0.15%     
===============================================
  Files              321      321              
  Lines            26297    26313      +16     
===============================================
+ Hits             16989    17040      +51     
+ Misses            9308     9273      -35     
Impacted Files Coverage Δ
src/rendering/SceneManager.cc 31.11% <12.50%> (+2.66%) ⬆️
src/rendering/RenderUtil.cc 39.55% <92.85%> (+0.62%) ⬆️
src/SdfEntityCreator.cc 86.24% <100.00%> (+0.33%) ⬆️
src/systems/hydrodynamics/Hydrodynamics.cc 88.15% <100.00%> (-0.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit 3448d05 into ign-gazebo6 Dec 1, 2022
@ahcorde ahcorde deleted the ahcorde/fix_light_tests branch December 1, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants