Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reset simulation tutorial #1824

Merged
merged 4 commits into from
Mar 1, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Nov 30, 2022

Signed-off-by: Alejandro Hernández Cordero [email protected]

🎉 New feature

Summary

Added reset simulation tutorial

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from mabelzhang as a code owner November 30, 2022 22:27
@ahcorde ahcorde self-assigned this Nov 30, 2022
@ahcorde ahcorde requested a review from mjcarroll as a code owner November 30, 2022 22:27
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 30, 2022

The Reset Gazebo transport API is exposed to allow resetting simulation to time zero.
It's possible to call this API using the command line or through the GUI.
In addition to the API, we have also expanded the simulation system API with a Reset interface.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there limitations to the Reset system - are there known things that might have trouble being reset?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjcarroll, when you implemented this feature, do you consider any limitations ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe that there are any major limitations with systems implementing the reset interface. They should have full access to the ECM functionality.

Systems that you may want to implement reset for are typically things that have a lot of loaded assets. This prevents having to reload those assets, and instead allow for a "warm" reboot of the system.

@mjcarroll
Copy link
Contributor

Friendly ping @ahcorde, there are some outstanding comments here.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from mabelzhang March 1, 2023 09:18
Copy link
Contributor

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a good break!

@ahcorde ahcorde merged commit 2e2689a into gz-sim7 Mar 1, 2023
@ahcorde ahcorde deleted the ahcorde/7/reset_simulation__tutorial branch March 1, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants