Skip to content

Removed unused attributes in view_angle plugin #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Removed unused attributes in view_angle plugin #1809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/gui/plugins/view_angle/ViewAngle.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,9 @@ namespace gz::sim
/// \brief Mutex to protect angle mode
public: std::mutex mutex;

/// \brief View Angle service name
public: std::string viewAngleService;

/// \brief View Control service name
public: std::string viewControlService;

/// \brief Move gui camera to pose service name
public: std::string moveToPoseService;

/// \brief gui camera pose
public: math::Pose3d camPose;

Expand Down Expand Up @@ -124,9 +118,6 @@ void ViewAngle::LoadConfig(const tinyxml2::XMLElement *)
if (this->title.empty())
this->title = "View Angle";

// For view angle requests
this->dataPtr->viewAngleService = "/gui/view_angle";

// view control requests
this->dataPtr->viewControlService = "/gui/camera/view_control";

Expand All @@ -135,9 +126,6 @@ void ViewAngle::LoadConfig(const tinyxml2::XMLElement *)
this->dataPtr->node.Subscribe(
topic, &ViewAngle::CamPoseCb, this);

// Move to pose service
this->dataPtr->moveToPoseService = "/gui/move_to/pose";

gz::gui::App()->findChild<
gz::gui::MainWindow *>()->installEventFilter(this);
}
Expand Down