Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pose in ViewAngle with GzPose #1641

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

AzulRadio
Copy link
Contributor

Signed-off-by: youhy [email protected]

New feature

Summary

As title. The behavior should be exactly the same as before.

viewangle_replace_demo

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@AzulRadio AzulRadio added GUI Gazebo's graphical interface (not pure Ignition GUI) OOBE 📦✨ Out-of-box experience labels Aug 10, 2022
@AzulRadio AzulRadio requested a review from jennuine August 10, 2022 20:42
@AzulRadio AzulRadio requested a review from chapulina as a code owner August 10, 2022 20:42
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1641 (5504e90) into ign-gazebo3 (1cf75f3) will increase coverage by 0.03%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-gazebo3    #1641      +/-   ##
===============================================
+ Coverage        77.94%   77.98%   +0.03%     
===============================================
  Files              255      255              
  Lines            15041    15041              
===============================================
+ Hits             11724    11730       +6     
+ Misses            3317     3311       -6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 94.51% <0.00%> (+1.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AzulRadio AzulRadio merged commit 8e8aab6 into ign-gazebo3 Aug 11, 2022
@AzulRadio AzulRadio deleted the azulradio/viewangle_gzpose branch August 11, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel GUI Gazebo's graphical interface (not pure Ignition GUI) OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants