Skip to content

Refactor: Utilizes function to sequence trajectories #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 1, 2022
Merged

Refactor: Utilizes function to sequence trajectories #1565

merged 5 commits into from
Jul 1, 2022

Conversation

onurtore
Copy link
Contributor

Utilizes new SequenceTrajectories function to sequence trajectories during
actor creation.

Part of three PR for the meta-ticket for slimming down the CreateActor function.

@onurtore onurtore force-pushed the otore19/SequenceTrajectories branch from 3a4528c to 555cbc8 Compare June 30, 2022 17:02
@onurtore onurtore mentioned this pull request Jun 30, 2022
Closed
@onurtore onurtore force-pushed the otore19/SequenceTrajectories branch from 555cbc8 to 8d52ef0 Compare June 30, 2022 17:09
ahcorde
ahcorde requested changes Jun 30, 2022
View reviewed changes
@onurtore onurtore force-pushed the otore19/SequenceTrajectories branch from 8d52ef0 to 71c605b Compare June 30, 2022 17:20
@onurtore onurtore requested a review from ahcorde June 30, 2022 17:21
ahcorde
ahcorde requested changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/rendering/SceneManager.cc~ is still there.

@onurtore onurtore force-pushed the otore19/SequenceTrajectories branch from 71c605b to 44557e8 Compare June 30, 2022 17:48
@onurtore
Copy link
Contributor Author

src/rendering/SceneManager.cc~ is still there.

@ahcorde, I had a problem with the file structure, other PR also messed up. Sorry for the trouble, its fixed now...

ahcorde
ahcorde requested changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to sign the commit https://github.com/gazebosim/gz-sim/pull/1565/checks?check_run_id=7136865810 ?

@onurtore onurtore force-pushed the otore19/SequenceTrajectories branch from 44557e8 to bb8743e Compare June 30, 2022 18:01
@onurtore
Copy link
Contributor Author

Do you mind to sign the commit https://github.com/gazebosim/gz-sim/pull/1565/checks?check_run_id=7136865810 ?

Done.

@ahcorde
Copy link
Contributor

ahcorde commented Jun 30, 2022

Do you mind to sign the commit https://github.com/gazebosim/gz-sim/pull/1565/checks?check_run_id=7136865810 ?

Done.

Nope, it's still there https://github.com/gazebosim/gz-sim/pull/1565/checks?check_run_id=7137067175

@onurtore
Copy link
Contributor Author

onurtore commented Jun 30, 2022 •
edited
Loading

Do you mind to sign the commit https://github.com/gazebosim/gz-sim/pull/1565/checks?check_run_id=7136865810 ?

Done.

Nope, it's still there https://github.com/gazebosim/gz-sim/pull/1565/checks?check_run_id=7137067175

But my commit ends with Signed-off-by: Onur Berk Tore [email protected] ?

@onurtore onurtore force-pushed the otore19/SequenceTrajectories branch 2 times, most recently from d11990e to 8854267 Compare June 30, 2022 18:12
@onurtore onurtore requested a review from ahcorde June 30, 2022 18:28
ahcorde
ahcorde requested changes Jun 30, 2022
View reviewed changes
@onurtore onurtore force-pushed the otore19/SequenceTrajectories branch from f9e0fca to 5e552cf Compare June 30, 2022 19:10
Utilizes function to sequence trajectories
d745d32 
Signed-off by: Onur Berk Töre <[email protected]>

Signed-off-by: Onur Berk Tore <[email protected]>
@onurtore onurtore force-pushed the otore19/SequenceTrajectories branch from 5e552cf to d745d32 Compare June 30, 2022 19:11
Fix documentation
6257cf9 
Signed-off-by: Onur Berk Tore <[email protected]>
ahcorde
ahcorde requested changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

   /github/workspace/include/ignition/gazebo/rendering/SceneManager.hh:206:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
  /github/workspace/src/rendering/SceneManager.cc:913:  Lines should be <= 80 characters long  [whitespace/line_length] [2]

Onur Berk Tore added 3 commits June 30, 2022 22:53
@onurtore onurtore requested a review from ahcorde June 30, 2022 19:57
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1565 (36117d9) into ign-gazebo6 (1f6c126) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           ign-gazebo6    #1565   +/-   ##
============================================
  Coverage        64.01%   64.01%           
============================================
  Files              317      317           
  Lines            25635    25638    +3     
============================================
+ Hits             16410    16413    +3     
  Misses            9225     9225
Impacted Files Coverage Δ
include/ignition/gazebo/rendering/SceneManager.hh 100.00% <ø> (ø)
src/rendering/SceneManager.cc 28.17% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6c126...36117d9. Read the comment docs.

@ahcorde ahcorde merged commit e826c71 into gazebosim:ign-gazebo6 Jul 1, 2022
@onurtore onurtore changed the title Utilizes function to sequence trajectories Refactor: Utilizes function to sequence trajectories Jul 2, 2022
liamhan0905 pushed a commit that referenced this pull request Jul 25, 2022
@liamhan0905
Utilizes function to sequence trajectories (#1565)
fcfb9b8 
Signed-off-by: Onur Berk Tore <[email protected]>
Signed-off-by: Liam Han <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

@chapulina chapulina Awaiting requested review from chapulina

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurtore @ahcorde