Skip to content

Use message field visualize_visual #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 20, 2022

Signed-off-by: ahcorde [email protected]

🦟 TODO

Related with #1378

Summary

Used visualize_visual from ign-msgs instead of a hardcoded value

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Apr 20, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 20, 2022
@ahcorde ahcorde mentioned this pull request Apr 20, 2022
4 tasks
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1453 (811c752) into main (6bc9542) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1453   +/-   ##
=======================================
  Coverage   35.01%   35.01%           
=======================================
  Files          44       44           
  Lines        2356     2356           
=======================================
  Hits          825      825           
  Misses       1531     1531           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc9542...811c752. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. I'm not sure if the sign flips on Conversions.cc are correct though

@ahcorde ahcorde requested a review from chapulina April 20, 2022 19:44
@chapulina chapulina merged commit dceb67d into main Apr 20, 2022
@chapulina chapulina deleted the ahcorde/light/visualize_visual branch April 20, 2022 22:14
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants