-
Notifications
You must be signed in to change notification settings - Fork 302
Set simulation time to Rendering #1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set simulation time to Rendering #1415
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1415 +/- ##
================================================
+ Coverage 33.58% 62.99% +29.41%
================================================
Files 44 301 +257
Lines 2260 24265 +22005
================================================
+ Hits 759 15286 +14527
- Misses 1501 8979 +7478 Continue to review full report at Codecov.
|
See gazebosim/gz-rendering#556 See gazebosim/gz-rendering#584 Signed-off-by: Matias N. Goldberg <[email protected]>
Signed-off-by: Matias N. Goldberg <[email protected]>
c2de743
to
c433f92
Compare
Signed-off-by: Matias N. Goldberg <[email protected]>
See gazebosim/gz-rendering#556
See gazebosim/gz-rendering#584
Signed-off-by: Matias N. Goldberg [email protected]
🦟 Bug fix
There is no ticket filed for this issue, but there is one at ign-rendering#556
Summary
Previously rendering was not being told of the current simulation time.
This is needed for proper particle FXs simulation and some postprocessing effects that rely on time.
This PR also accounts for a hack required only by ign-rendering6 so that SetTime() is honoured (otherwise legacy behavior is used, which uses real time instead of simulation time). Details of this legacy issue can be found in my reply.
This PR should be merged AFTER ign-rendering6's ign-rendering#584
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.