Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable triggered publisher tests #1271

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Re-enable triggered publisher tests #1271

merged 1 commit into from
Jan 10, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

The tests should pass now that the SDFormat issue has been fixed upstream.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from scpeters January 4, 2022 20:11
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 4, 2022
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #1271 (cf660da) into main (a95a584) will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
+ Coverage   61.71%   61.97%   +0.25%     
==========================================
  Files         274      276       +2     
  Lines       22740    22999     +259     
==========================================
+ Hits        14035    14253     +218     
- Misses       8705     8746      +41     
Impacted Files Coverage Δ
.../systems/triggered_publisher/TriggeredPublisher.cc 83.72% <0.00%> (ø)
.../systems/triggered_publisher/TriggeredPublisher.hh 100.00% <0.00%> (ø)
src/EntityComponentManager.cc 88.38% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95a584...cf660da. Read the comment docs.

@chapulina chapulina merged commit 15ed280 into main Jan 10, 2022
@chapulina chapulina deleted the chapulina/7/triggered branch January 10, 2022 19:53
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants