Backport gazebo::Util::validTopic() from ign-gazebo4. #1153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Supports #869
Summary
Function
gazebo::Util::validTopic()
has been added in #522 to ign-gazebo4. The function doesn't break any API or ABI, so I think it makes sense to backport it to 3. I made use of this function in #869 while targeted to 4, and now I retargeted to 3 and this function was missing.I think porting the rest of #522 might change some behavior, so I don't recommend porting the whole PR.
Test it
The unit test has been backported, too.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge