Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport gazebo::Util::validTopic() from ign-gazebo4. #1153

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Nov 1, 2021

🎉 New feature

Supports #869

Summary

Function gazebo::Util::validTopic() has been added in #522 to ign-gazebo4. The function doesn't break any API or ABI, so I think it makes sense to backport it to 3. I made use of this function in #869 while targeted to 4, and now I retargeted to 3 and this function was missing.

I think porting the rest of #522 might change some behavior, so I don't recommend porting the whole PR.

Test it

The unit test has been backported, too.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@peci1 peci1 requested a review from chapulina as a code owner November 1, 2021 17:00
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Nov 1, 2021
@peci1 peci1 mentioned this pull request Nov 1, 2021
8 tasks
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #1153 (511a40d) into ign-gazebo3 (6322451) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3    #1153      +/-   ##
===============================================
+ Coverage        77.45%   77.47%   +0.01%     
===============================================
  Files              222      222              
  Lines            12758    12769      +11     
===============================================
+ Hits              9882     9893      +11     
  Misses            2876     2876              
Impacted Files Coverage Δ
include/ignition/gazebo/Util.hh 100.00% <ø> (ø)
src/Util.cc 93.39% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6322451...511a40d. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chapulina chapulina merged commit 9cafc6b into gazebosim:ign-gazebo3 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants