Skip to content

Update Select Entities GUI plugin to use Entity type #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 26, 2021

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

similar to #1144, this PR replaces use of unsigned int / int with Entity for entity ids.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@iche033 iche033 requested a review from chapulina as a code owner October 26, 2021 23:40
@iche033 iche033 requested a review from adlarkin October 26, 2021 23:41
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1146 (45493fa) into ign-gazebo6 (40e5f25) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1146      +/-   ##
===============================================
- Coverage        63.73%   63.70%   -0.03%     
===============================================
  Files              256      256              
  Lines            20116    20116              
===============================================
- Hits             12820    12814       -6     
- Misses            7296     7302       +6     
Impacted Files Coverage Δ
src/gui/plugins/select_entities/SelectEntities.cc 10.04% <0.00%> (ø)
src/rendering/SceneManager.cc 28.55% <ø> (ø)
src/SimulationRunner.cc 92.91% <0.00%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e5f25...45493fa. Read the comment docs.

@chapulina chapulina merged commit 9e00fc8 into ign-gazebo6 Oct 27, 2021
@chapulina chapulina deleted the select_entities_id branch October 27, 2021 05:20
srmainwaring pushed a commit to srmainwaring/gz-sim that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants