Fix minimal scene render engine gui name from command line arg #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
ahcorde
added
needs upstream release
chapulina
added
beta
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Great idea to set a property on the window, works for me! 👍
I pushed some changes in c6cfb44 so we don't need to deprecated the public functions. Adding an argument that has a default value on a new major release is fine, because it breaks ABI, but doesn't break API.
|
@osrf-jenkins run tests pleaseee |
chapulina
removed
the
needs upstream release
Codecov Report
@@ Coverage Diff @@
## main #1034 +/- ##
==========================================
- Coverage 63.40% 63.39% -0.01%
==========================================
Files 240 240
Lines 19548 19551 +3
==========================================
Hits 12394 12394
- Misses 7154 7157 +3
Continue to review full report at Codecov.
|
WilliamLewww
pushed a commit
to WilliamLewww/ign-gazebo
that referenced
this pull request
Dec 7, 2021
…osim#1034) Signed-off-by: ahcorde <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Signed-off-by: William Lew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde [email protected]
🦟 Bug fix
Summary
The render engine GUI name was not passed to the GUI side, the minimal scene was not aware of the render engine GUI name when it was defined in the command line arguments. This PR fixes the issue and allows to change the render engine of the minimal scene using the command line. If the command line is defined will overwrite the value defined in the sdf.
Require:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge