-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configuring point size in Visualize Lidar GUI plugin #1021
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor style fix
Signed-off-by: Ian Chen <[email protected]>
cpplint is failing. Fixed here #1025 |
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1021 +/- ##
===============================================
- Coverage 64.07% 64.04% -0.03%
===============================================
Files 255 255
Lines 20051 20051
===============================================
- Hits 12847 12841 -6
- Misses 7204 7210 +6
Continue to review full report at Codecov.
|
…azebosim#1021) * add spinbox to configure point size Signed-off-by: Ian Chen <[email protected]> * cap letter Signed-off-by: Ian Chen <[email protected]> * remove empty line Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: William Lew <[email protected]>
🎉 New feature
depends on gazebosim/gz-rendering#392
Summary
Added a spin box for configuring size of lidar point visualization in
Visualize Lidar
plugin. Note it only affectsPoint
visualization type. Works forogre
andogre2
render engine.Test it
Launch an example world with gpu ray sensor, e.g.:
Open the
Visualize Lidar
GUI plugin by going to the top right menu (3 vertical dots), scroll down and click onVisualize Lidar
.Unpause the simulation by hitting the play button
Refresh the topic drop down list and select the
/lidar
topicSelect
Points
Visual Type to see the default point visualization with size1
Change
Point Size
to5
and hit Enter to see larger points.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge