Skip to content

Fix destroying wide angle camera #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2022
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 12, 2022

🦟 Bug fix

This fixes gz-sensors7's INTEGRATION_wide_angle_camera_test for me.

To test:

  1. build gz-sensors7 in your worksapce

  2. Runt the test with ogre render engine from your colcon workspace:

    RENDER_ENGINE_VALUES=ogre ./build/gz-sensors7/bin/INTEGRATION_wide_angle_camera
    

    The test should now pass instead of segfault.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #718 (cd05b38) into gz-rendering7 (da973f5) will not change coverage.
The diff coverage is n/a.

❗ Current head cd05b38 differs from pull request most recent head 1bd01e4. Consider uploading reports for the commit 1bd01e4 to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering7     #718   +/-   ##
==============================================
  Coverage          74.14%   74.14%           
==============================================
  Files                164      164           
  Lines              14351    14351           
==============================================
  Hits               10641    10641           
  Misses              3710     3710           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit 7e3371b into gz-rendering7 Sep 16, 2022
@ahcorde ahcorde deleted the wide_angle_camera_ogre_test branch September 16, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants