Skip to content

Provide a Virtual Method Anchor for Classes in Headers #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/gz/rendering/ArrowVisual.hh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace gz
public virtual CompositeVisual
{
/// \brief Destructor
public: virtual ~ArrowVisual() { }
public: virtual ~ArrowVisual();

/// \brief Get arrow-head visual
/// \return The arrow-head visual
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/AxisVisual.hh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace gz
public virtual CompositeVisual
{
/// \brief Destructor
public: virtual ~AxisVisual() { }
public: virtual ~AxisVisual();

/// \brief set true to show the axis heads, false otherwise
/// \param[in] _b true to show the axis heads, false otherwise
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/BoundingBoxCamera.hh
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ namespace gz
public virtual Camera
{
/// \brief Destructor
public: virtual ~BoundingBoxCamera() { }
public: virtual ~BoundingBoxCamera();

/// \brief Get the BoundingBox data
/// \return Buffer of bounding boxes info (label, minX, minY, maxX, maxY).
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/COMVisual.hh
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace gz
public virtual Visual
{
/// \brief Destructor
public: virtual ~COMVisual() {}
public: virtual ~COMVisual();

/// \brief Set the inertial component of the visual
/// \param[in] _inertial Inertial component of the visual
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/Camera.hh
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ namespace gz
unsigned int, unsigned int, const std::string&)> NewFrameListener;

/// \brief Destructor
public: virtual ~Camera() { }
public: virtual ~Camera();

/// \brief Get the image width in pixels
/// \return The image width in pixels
Expand Down
3 changes: 2 additions & 1 deletion include/gz/rendering/Capsule.hh
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#define GZ_RENDERING_CAPSULE_HH_

#include "gz/rendering/config.hh"
#include "gz/rendering/Export.hh"
#include "gz/rendering/Geometry.hh"
#include "gz/rendering/Object.hh"

Expand All @@ -33,7 +34,7 @@ namespace gz
public virtual Geometry
{
/// \brief Destructor
public: virtual ~Capsule() { }
public: virtual ~Capsule();

/// \brief Set the radius of the capsule
public: virtual void SetRadius(double _radius) = 0;
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/CompositeVisual.hh
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace gz
public virtual Visual
{
/// \brief Destructor
public: virtual ~CompositeVisual() { }
public: virtual ~CompositeVisual();
};
}
}
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/DepthCamera.hh
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace gz
unsigned int, unsigned int, const std::string&)> NewFrameListener;

/// \brief Destructor
public: virtual ~DepthCamera() { }
public: virtual ~DepthCamera();

/// \brief Create a texture which will hold the depth data
public: virtual void CreateDepthTexture() = 0;
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/Geometry.hh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ namespace gz
public virtual Object
{
/// \brief Destructor
public: virtual ~Geometry() { }
public: virtual ~Geometry();

/// \brief Determine if this Geometry is attached to a Visual
/// \return True if this Geometry has a parent Visual
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/GizmoVisual.hh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace gz
public virtual CompositeVisual
{
/// \brief Destructor
public: virtual ~GizmoVisual() { }
public: virtual ~GizmoVisual();

/// \brief Set the transform mode of the gizmo. This controls the visual
/// appearance of the gizmo. Only the visuals in the specified mode will
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/GpuRays.hh
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace gz
unsigned int, unsigned int, const std::string&)> NewFrameListener;

/// \brief Destructor
public: virtual ~GpuRays() { }
public: virtual ~GpuRays();

/// \brief All things needed to get back z buffer for gpu rays data.
/// \return Array of gpu rays data.
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/Grid.hh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace gz
public virtual Geometry
{
/// \brief Destructor
public: virtual ~Grid() { }
public: virtual ~Grid() = 0;

/// \brief Set the number of cells on a planar grid
/// \param[in] _count The number of cells
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/InertiaVisual.hh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ namespace gz
public virtual Visual
{
/// \brief Destructor
public: virtual ~InertiaVisual() {}
public: virtual ~InertiaVisual();

/// \brief Set the inertial component of the visual
/// \param[in] _inertial Inertial component of the visual
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/JointVisual.hh
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ namespace gz
public virtual Visual
{
/// \brief Destructor
public: virtual ~JointVisual() {}
public: virtual ~JointVisual();

/// \brief Create an axis and attach it to the joint visual.
/// \param[in] _axis Axis vector.
Expand Down
8 changes: 4 additions & 4 deletions include/gz/rendering/Light.hh
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace gz
public virtual Node
{
/// \brief Destructor
public: virtual ~Light() { }
public: virtual ~Light();

/// \brief Get the diffuse color
/// \return The diffuse color
Expand Down Expand Up @@ -122,7 +122,7 @@ namespace gz
public virtual Light
{
/// \brief Destructor
public: virtual ~DirectionalLight() { }
public: virtual ~DirectionalLight();

/// \brief Get the direction of the light
/// \return The direction of the light
Expand All @@ -145,7 +145,7 @@ namespace gz
public virtual Light
{
/// \brief Destructor
public: virtual ~PointLight() { }
public: virtual ~PointLight();
};

/// \class SpotLight Light.hh gz/rendering/Light.hh
Expand All @@ -154,7 +154,7 @@ namespace gz
public virtual Light
{
/// \brief Destructor
public: virtual ~SpotLight() { }
public: virtual ~SpotLight();

/// \brief Get direction of the light
/// \return The direction of the light
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/LightVisual.hh
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ namespace gz
public virtual Visual
{
/// \brief Descructor
public: virtual ~LightVisual() {}
public: virtual ~LightVisual();

/// \brief set type of the light
/// \param[in] _type type of the light
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/Material.hh
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ namespace gz
public virtual Object
{
/// \brief Destructor
public: virtual ~Material() { }
public: virtual ~Material();

/// \brief Determine if lighting affects this material
/// \return True if lighting affects this material
Expand Down
4 changes: 2 additions & 2 deletions include/gz/rendering/Mesh.hh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace gz
public virtual Geometry
{
/// \brief Destructor
public: virtual ~Mesh() { }
public: virtual ~Mesh();

/// \brief Check whether the mesh has skeleton
/// \return True if the mesh has skeleton
Expand Down Expand Up @@ -136,7 +136,7 @@ namespace gz
public virtual Object
{
/// \brief Destructor
public: virtual ~SubMesh() { }
public: virtual ~SubMesh();

/// \brief Get the currently assigned material
/// \return The currently assigned material
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/Node.hh
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ namespace gz
public virtual Object
{
/// \brief Destructor
public: virtual ~Node() { }
public: virtual ~Node();

/// \brief Determine if this Node is attached to another Node.
/// \return True if this Node has a parent Node
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/Object.hh
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace gz
class GZ_RENDERING_VISIBLE Object
{
/// \brief Destructor
public: virtual ~Object() { }
public: virtual ~Object();

/// \brief Get the object ID. This ID will be unique across all objects
/// inside a given scene, but necessarily true for objects across
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/ParticleEmitter.hh
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ namespace gz
public virtual Visual
{
/// \brief Destructor
public: virtual ~ParticleEmitter() {}
public: virtual ~ParticleEmitter();

/// \brief \brief Get the emitter type.
/// \return Emitter type.
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/RayQuery.hh
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ namespace gz
: public virtual Object
{
/// \brief Destructor
public: virtual ~RayQuery() { }
public: virtual ~RayQuery();

/// \brief Set ray origin
/// \param[in] _origin Ray origin
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/RenderEngine.hh
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace gz
class GZ_RENDERING_VISIBLE RenderEngine
{
/// \brief Destructor
public: virtual ~RenderEngine() { }
public: virtual ~RenderEngine();

/// \brief Load any necessary resources to set up render-engine. This
/// should called before any other function.
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/RenderPass.hh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace gz
: public virtual Object
{
/// \brief Destructor
public: virtual ~RenderPass() { }
public: virtual ~RenderPass();

/// \brief Set to enable or disable the render pass
/// \param[in] _enabled True to enable the render pass, false to disable.
Expand Down
6 changes: 3 additions & 3 deletions include/gz/rendering/RenderTarget.hh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace gz
public virtual Object
{
/// \brief Destructor
public: virtual ~RenderTarget() { }
public: virtual ~RenderTarget();

/// \brief Get render target width in pixels
/// \return The render target width in pixels
Expand Down Expand Up @@ -104,7 +104,7 @@ namespace gz
public virtual RenderTarget
{
/// \brief Destructor
public: virtual ~RenderTexture() { }
public: virtual ~RenderTexture();

/// \brief Returns the OpenGL texture Id. A valid Id is returned only
// if this is an OpenGL render texture
Expand All @@ -127,7 +127,7 @@ namespace gz
public virtual RenderTarget
{
/// \brief Destructor
public: virtual ~RenderWindow() { }
public: virtual ~RenderWindow();

/// \brief Get the window handle that the render window is attached to.
/// \return Window handle
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/Scene.hh
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ namespace gz
class GZ_RENDERING_VISIBLE Scene
{
/// \brief Destructor
public: virtual ~Scene() { }
public: virtual ~Scene();

/// \brief Load scene-specific resources
public: virtual void Load() = 0;
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/SegmentationCamera.hh
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ namespace gz
public virtual Camera
{
/// \brief Destructor
public: virtual ~SegmentationCamera() { }
public: virtual ~SegmentationCamera();

/// \brief Create a texture which will hold the segmentation data
public: virtual void CreateSegmentationTexture() = 0;
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/Sensor.hh
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace gz
public virtual Node
{
/// \brief Sensor
public: virtual ~Sensor() { }
public: virtual ~Sensor();

/// \brief Set visibility mask
/// \param[in] _mask Visibility mask
Expand Down
8 changes: 4 additions & 4 deletions include/gz/rendering/Storage.hh
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ namespace gz
typedef std::shared_ptr<const T> ConstTPtr;

/// \brief Destructor
public: virtual ~Map() { }
public: virtual ~Map() = default;

/// \brief Get the number of elements in this map
/// \return The number of elements in this map
Expand Down Expand Up @@ -122,7 +122,7 @@ namespace gz
typedef std::shared_ptr<const T> ConstTPtr;

/// \brief Destructor
public: virtual ~Store() { }
public: virtual ~Store() = default;

/// \brief Get number of elements in this store
/// \return The number of elements in this store
Expand Down Expand Up @@ -244,7 +244,7 @@ namespace gz
typedef std::shared_ptr<const TStore> ConstTStorePtr;

/// \brief Destructor
public: virtual ~CompositeStore() { }
public: virtual ~CompositeStore() = default;

/// \brief Get number of Stores
/// \return The number of Stores
Expand Down Expand Up @@ -291,7 +291,7 @@ namespace gz
class GZ_RENDERING_VISIBLE StoreWrapper :
public Store<T>
{
public: virtual ~StoreWrapper() { }
public: virtual ~StoreWrapper() = default;
};

// armhf failed to build with this code. It can not be removed for the rest
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/Text.hh
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ namespace gz
public: Text() = default;

/// \brief Destructor
public: virtual ~Text() = default;
public: virtual ~Text();

/// \brief Set the font.
/// \param[in] _font Name of the font
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/ThermalCamera.hh
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace gz
public virtual Camera
{
/// \brief Destructor
public: virtual ~ThermalCamera() { }
public: virtual ~ThermalCamera();

/// \brief Set the ambient temperature of the environment
/// \param[in] _ambient Ambient temperature in kelvin
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/ViewController.hh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace gz
class GZ_RENDERING_VISIBLE ViewController
{
/// \brief Destructor
public: virtual ~ViewController() { }
public: virtual ~ViewController();

/// \brief Set the camera that will be controlled by this view controller.
/// \param[in] _camera Camera to control
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/Visual.hh
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace gz
public virtual Node
{
/// \brief Destructor
public: virtual ~Visual() { }
public: virtual ~Visual();

/// \brief Get the number of geometries attached to this visual
/// \return The number of geometries attached to this visual
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/WideAngleCamera.hh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace gz
public virtual Camera
{
/// \brief Destructor
public: virtual ~WideAngleCamera() { }
public: virtual ~WideAngleCamera();

/// \brief Set the camera lens to use for this wide angle camera
/// \param[in] _lens Camera lens to set
Expand Down
Loading