Fix crash when hovering the cursor in heightmap.sdf

[darksylinc]

Summary

Hovering the cursor while in the ign gui when heightmap.sdf is opened
would cause a shader compiler error.

The triggering condition was having a directional light without shadow
nodes.

This error is from upstream
OGRECave/ogre-next@e40bc53

Signed-off-by: Matias N. Goldberg [email protected]

🦟 Bug fix

No ticket was assigned for this bug

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #536 (01af4ca) into ign-rendering6 (c10c303) will decrease coverage by 0.01%.
The diff coverage is 41.17%.

@@                Coverage Diff                 @@
##           ign-rendering6     #536      +/-   ##
==================================================
- Coverage           54.38%   54.37%   -0.02%     
==================================================
  Files                 198      198              
  Lines               20087    20096       +9     
==================================================
+ Hits                10925    10927       +2     
- Misses               9162     9169       +7     

Impacted Files	Coverage Δ
ogre2/src/Ogre2Material.cc	70.88% <0.00%> (-0.29%)	⬇️
ogre2/src/Ogre2MaterialSwitcher.cc	84.41% <53.84%> (-5.59%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73b9fa1...01af4ca. Read the comment docs.

[iche033]

hmm I don't get the shader compile error when I ran heightmap.sdf and hover the mouse over the terrain. Changes look fine though.

[darksylinc]

hmm I don't get the shader compile error when I ran heightmap.sdf and hover the mouse over the terrain

Shortly after I submitted the PR I remembered the terrain shadows on objects aren't working because the listener is being accidentally overriden (we discussed this, has a simple solution for Fortress) so it doesn't crash because it's not working.

A follow up PR can fix that though

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1