Skip to content

Resolve updated codecheck issues #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Resolve updated codecheck issues #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ogre/src/OgreRenderEngine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,8 +493,11 @@ void OgreRenderEngine::CreateRenderSystem()
renderSys = rsList->at(c);
c++;
}
while (renderSys &&
renderSys->getName().compare("OpenGL Rendering Subsystem") != 0);
// cpplint has a false positive when extending a while call to multiple lines
// (it thinks the while loop is empty), so we must put the whole while
// statement on one line and add NOLINT at the end so that cpplint doesn't
// complain about the line being too long
while (renderSys && renderSys->getName().compare("OpenGL Rendering Subsystem") != 0); // NOLINT

if (renderSys == nullptr)
{
Expand Down
7 changes: 5 additions & 2 deletions ogre2/src/Ogre2RenderEngine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,8 +476,11 @@ void Ogre2RenderEngine::CreateRenderSystem()
renderSys = rsList->at(c);
c++;
}
while (renderSys &&
renderSys->getName().compare("OpenGL 3+ Rendering Subsystem") != 0);
// cpplint has a false positive when extending a while call to multiple lines
// (it thinks the while loop is empty), so we must put the whole while
// statement on one line and add NOLINT at the end so that cpplint doesn't
// complain about the line being too long
while (renderSys && renderSys->getName().compare("OpenGL 3+ Rendering Subsystem") != 0); // NOLINT

if (renderSys == nullptr)
{
Expand Down