Download dependencies #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Shepherd <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools4 #123 +/- ##
===================================================
+ Coverage 77.12% 77.26% +0.13%
===================================================
Files 19 19
Lines 2535 2555 +20
===================================================
+ Hits 1955 1974 +19
- Misses 580 581 +1
Continue to review full report at Codecov.
|
added 3 commits
October 2, 2020 12:36
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
|
Should we also add support for |
I'll leave that up to @nkoenig . Could you add some tests? Probably somewhere here: https://github.com/ignitionrobotics/ign-fuel-tools/blob/d892487b4e99b1bb8197ccbcb4533731831de4fa/src/FuelClient_TEST.cc#L397 |
Sure, I'm currently working on base case example model that I'll add to the tests once I can upload it. |
Signed-off-by: John Shepherd <[email protected]>
|
I added support for downloading dependencies from |
…_dep_download Add support for model config dependencies
|
Converting to draft until I can get some tests in |
JShep1
added
the
needs upstream release
Signed-off-by: John Shepherd <[email protected]>
nkoenig
requested changes
Nov 5, 2020
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
|
Support for |
|
I'm getting the same test failure locally as CI. |
|
@osrf-jenkins run tests now that |
chapulina
removed
the
needs upstream release
|
@nkoenig Could I get a re-review? Not sure why Github isn't letting me re-request. |
nkoenig
approved these changes
Nov 30, 2020
nkoenig
added a commit
that referenced
this pull request
Dec 9, 2020
* Use lowercase resource and owner names when storing assets on disk (#130) * Use lowercase resource and owner names when storing assets on disk Signed-off-by: Nate Koenig <[email protected]> * Remove added diff text from merge Signed-off-by: John Shepherd <[email protected]> * change model version in test back Signed-off-by: John Shepherd <[email protected]> * Fix test Signed-off-by: Nate Koenig <[email protected]> * Fix windows Signed-off-by: Nate Koenig <[email protected]> * Fix more windows tests Signed-off-by: Nate Koenig <[email protected]> * Testing another windows fix Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: John Shepherd <[email protected]> * Prepare for 3.5.0 release (#135) * Prepare for 3.5.0 release Signed-off-by: Nate Koenig <[email protected]> * Update Changelog.md Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Download model dependencies (#123) Signed-off-by: John Shepherd <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Prepare for 4.3.0 release (#139) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Set keep alive on (#141) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: John Shepherd <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
nkoenig
added a commit
that referenced
this pull request
Dec 23, 2020
* Use lowercase resource and owner names when storing assets on disk (#130) * Use lowercase resource and owner names when storing assets on disk Signed-off-by: Nate Koenig <[email protected]> * Remove added diff text from merge Signed-off-by: John Shepherd <[email protected]> * change model version in test back Signed-off-by: John Shepherd <[email protected]> * Fix test Signed-off-by: Nate Koenig <[email protected]> * Fix windows Signed-off-by: Nate Koenig <[email protected]> * Fix more windows tests Signed-off-by: Nate Koenig <[email protected]> * Testing another windows fix Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: John Shepherd <[email protected]> * Prepare for 3.5.0 release (#135) * Prepare for 3.5.0 release Signed-off-by: Nate Koenig <[email protected]> * Update Changelog.md Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Download model dependencies (#123) Signed-off-by: John Shepherd <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Prepare for 4.3.0 release (#139) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Set keep alive on (#141) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Support editing/patching model files (#140) * Support editing/patching model files Signed-off-by: Nate Koenig <[email protected]> * Added documentation Signed-off-by: Nate Koenig <[email protected]> * Set keep alive on Signed-off-by: Nate Koenig <[email protected]> * Documentation and tests Signed-off-by: Nate Koenig <[email protected]> * One more test and exit catch missing -u Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Prepare for 5.1.0 release (#145) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Fix light map URI (#146) Signed-off-by: Ian Chen <[email protected]> * Bump to 5.1.1 (#147) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: John Shepherd <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloads all models in the
<dependency>tag within a given model'smetadata.pbtxtfile and within the<depend>tag in amodel.config. Cyclic dependencies are also allowed. A step towards getting #111 resolved.Depends on https://github.com/ignitionrobotics/ign-msgs/pull/91/files
Signed-off-by: John Shepherd [email protected]