More file path APIs #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
github-actions
bot
added
🏰 citadel
Codecov Report
@@ Coverage Diff @@
## ign-common3 #70 +/- ##
===============================================
+ Coverage 73.71% 73.72% +0.01%
===============================================
Files 68 68
Lines 9283 9287 +4
===============================================
+ Hits 6843 6847 +4
Misses 2440 2440
Continue to review full report at Codecov.
|
2 tasks
mjcarroll
reviewed
Jun 8, 2020
mjcarroll
reviewed
Jun 8, 2020
mjcarroll
reviewed
Jun 8, 2020
mjcarroll
requested changes
Jun 8, 2020
Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
mjcarroll
approved these changes
Jun 9, 2020
mjcarroll
pushed a commit
that referenced
this pull request
Oct 14, 2020
Signed-off-by: Louise Poubel <[email protected]>
mjcarroll
pushed a commit
that referenced
this pull request
Oct 19, 2020
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a couple of functions that I'm using to tackle gazebosim/gz-sim#123 :
common::SystemPaths::FilePathEnv- not to make assumptions about the current value, since we can't be surecommon::SystemPaths::SetFilePathEnvhasn't been called.common::systemPaths- we've been exposing function by function of the global instance ofSystemPathsthoughUtils. Instead, just expose the pointer so the functions can be called directly.