-
Notifications
You must be signed in to change notification settings - Fork 202
Added documentation for usage of setup-gazebo #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Saurabh Kamat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for adding this documentation. I only have one small comment.
setup_gazebo_in_ci.md
Outdated
|
||
* Citadel | ||
* Fortress | ||
* Garden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Garden is pretty much EOL now, so it can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing it out.
However, currently, the action reads from the collections file - https://github.com/gazebo-tooling/release-tools/blob/8483b5c73e47aa1e098f7dbbee29a7b3fc0ae3b8/jenkins-scripts/dsl/gz-collections.yaml#L190
So it will still support the installation of Garden as long as it is in that file. Would you still like me to remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we can remove it yes. I will remove it from collections as soon as the release is EOL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. I have removed the mention of Garden.
Signed-off-by: Saurabh Kamat <[email protected]>
Thanks @sauk2 for the PR. I think that there is a good part of the content directly copied from the README.md in the setup-gazebo repository. I'm worried about the amount of maintenance work that this can cause when we update/change the setup-gazebo README. I would be more inclined to create a single document where we point the users to read the README file in github or the Marketplace instructions (the same text) of the setup-gazebo instead of recreating the content here. We can have a nice introduction about CI like the one we have now. |
Signed-off-by: Saurabh Kamat <[email protected]>
Thanks for the feedback! This makes a lot of sense. I have updated instructions to direct users to the Marketplace page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Added documentation for usage of setup-gazebo Signed-off-by: Saurabh Kamat <[email protected]> * Removed garden from setup-gazebo docs Signed-off-by: Saurabh Kamat <[email protected]> * Updated setup-gazebo usage instructions Signed-off-by: Saurabh Kamat <[email protected]> --------- Signed-off-by: Saurabh Kamat <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
🎉 New feature
Closes #529
Summary
Added a new section with information on
setup-gazebo
, followed by subsections on how to use it on each of the three supported platforms.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.