Skip to content

Replace the use of wget by curl in _install docs #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

j-rivero
Copy link
Contributor

There is a bug in the Harmonic instructions by using curl with the option of -O which is not the same than --output in curl but it is correct if you use grep. The PR changes all the occurrences of wget in supported install* docs to use curl instead of wget.

With curl:

  • --output <file> will write output to the
  • -O will write output to a file named the same than the remote file
  • will write output to stdout.

The PR also change to use https everywhere.

@j-rivero j-rivero requested a review from mabelzhang as a code owner June 10, 2024 16:18
@github-actions github-actions bot added 🌱 garden Gazebo Garden 🎵 harmonic Gazebo Harmonic 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jun 10, 2024
j-rivero added 2 commits June 11, 2024 15:47
Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero j-rivero requested a review from azeey June 11, 2024 17:14
@azeey azeey merged commit adf33db into master Jun 12, 2024
1 check passed
@azeey azeey deleted the jrivero/use_curl_instructions branch June 12, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress 🌱 garden Gazebo Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants