Skip to content

Include how to run Gazebo and rework the sections in the ROS vendor d… #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2024

Conversation

j-rivero
Copy link
Contributor

Inspired by a question from the user in the forum, I started adding a section about how to just run the simulator with vendor packages.

After that I tried to add some more headers to facilitate finding the right information, prioritizing how to run and build software using the vendor packages in the default combination provided. I assume that is what most of the users really want.

Finally, I'm scoping the last two points into an "Expert" section so newbies don't fall in trying that. I've reused the expression "Installing Non-Default Gazebo/ROS 2 Pairings with vendor packages" which is the one that we have in https://gazebosim.org/docs/latest/ros_installation document.

@j-rivero j-rivero requested a review from mabelzhang as a code owner May 27, 2024 14:56
@j-rivero j-rivero requested review from azeey and removed request for mabelzhang May 27, 2024 14:56
@@ -12,6 +14,8 @@ more up-to-date Gazebo packages were copied to the ROS bootstrap repository
versions in sync between the Gazebo and ROS package repositories was difficult
since this was a manual process.

## Gazebo vendor packages in ROS 2 Jazzy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine the content will be relevant even after Jazzy, so maybe remove Jazzy or indicate that this is for Jazzy and later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j-rivero and others added 2 commits May 29, 2024 16:13
Signed-off-by: Jose Luis Rivero <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero j-rivero requested a review from azeey May 29, 2024 14:14
@azeey azeey merged commit 9383b6c into master May 29, 2024
1 check passed
@azeey azeey deleted the jrivero/improvements_to_vendor branch May 29, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants