-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(gatsby-source-shopify): upgrade from Shopify API version 2024-04 to 2025-01 #39247
Conversation
packages/gatsby-source-shopify/src/type-builders/location-type.ts
Outdated
Show resolved
Hide resolved
@@ -19,23 +19,20 @@ export function productVariantTypeBuilder(prefix: string): string { | |||
presentmentPrices: [${prefix}ProductVariantPricePair!]! | |||
price: Float! | |||
product: ${prefix}Product! @link(from: "_product", by: "id") | |||
requiresShipping: Boolean! @deprecated(reason: "Use \`InventoryItem.requiresShipping\` instead.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Field has been fully removed now
packages/gatsby-source-shopify/src/type-builders/product-variant-type.ts
Show resolved
Hide resolved
packages/gatsby-source-shopify/src/type-builders/location-type.ts
Outdated
Show resolved
Hide resolved
@@ -112,7 +117,6 @@ export class ProductVariantsQuery extends BulkQuery { | |||
product { | |||
id | |||
} | |||
requiresShipping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field has been fully removed now
serviceName: String! | ||
shippingMethods: [${prefix}ShippingMethod!]! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated in 2024-10
then removed in the following version
e78af39
to
31dfa61
Compare
packages/gatsby-source-shopify/src/type-builders/location-type.ts
Outdated
Show resolved
Hide resolved
c6e95b8
to
295f40a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my side and things seem great! Let's get this in and have at least @next
released asap
…4 to 2025-01 (#39247) * chore: sort the queried fields * feat: address breaking api changes when upgrading to 2024-07 * feat!: address breaking changes when upgrading to 2024-10 * fix: address breaking changes when upgrading to 2025-01 * fix: add deprecation message for fulfillmentOrdersOptIn * fix: make measurement a required field to match shopify api response * fix: object definition already in common * fix: add backwards compatibility for weight/weightUnit fields * fix: add deprecation messages for proxied quantities fields * test: update snapshots (cherry picked from commit 132013c)
…4 to 2025-01 (#39247) (#39252) * feat!(gatsby-source-shopify): upgrade from Shopify API version 2024-04 to 2025-01 (#39247) * chore: sort the queried fields * feat: address breaking api changes when upgrading to 2024-07 * feat!: address breaking changes when upgrading to 2024-10 * fix: address breaking changes when upgrading to 2025-01 * fix: add deprecation message for fulfillmentOrdersOptIn * fix: make measurement a required field to match shopify api response * fix: object definition already in common * fix: add backwards compatibility for weight/weightUnit fields * fix: add deprecation messages for proxied quantities fields * test: update snapshots (cherry picked from commit 132013c) * chore: bump caniuse-lite * ci: pin pnpm used in pnpm integration tests to v9 (#39248) v10 has a lot of breaking changes: https://github.com/pnpm/pnpm/releases/tag/v10.0.0. * test: use branch/alias deploys for e2e test suite (#39222) * test: use branch/alias deploys for e2e test suite * test: use permalink url and not alias url --------- Co-authored-by: Michal Piechowiak <[email protected]> --------- Co-authored-by: Mateusz Bocian <[email protected]> Co-authored-by: Michal Piechowiak <[email protected]> Co-authored-by: Philippe Serhal <[email protected]>
This was released:
|
Description
This upgrades the default Shopify API version in
gatsby-source-shopify
from 2024-04 to 2025-01.Due to fields being moved/removed in the Shopify API, this upgrade includes breaking changes.
ProductVariant.requiresShipping
has been removed but is still available atInventoryItem.requiresShipping
InventoryItem.productBased
andInventoryItem.shippingMethods
have been removedLocations.fulfillmentService.shippingMethods
has been removedShopifyProductVariant.weight
andShopifyProductVariant.weightUnit
now requirelocations
to be set in yourshopifyConnections
via the plugin options.We have also deprecated a number of fields. Please update your system to use the recommended alternative to avoid breaking changes in future version changes.
ShopifyProductVariant.weight
andShopifyProductVariant.weightUnit
should be migrated to useInventoryItem.measurement.weight
ShopifyFulfillmentService.fulfillmentOrdersOptIn
is deprecated upstream in the ShopifyApiShopifyInventoryLevel.quantities
instead:ShopifyInventoryLevel.available
ShopifyInventoryLevel.incoming
ShopifyInventoryLevel.committed
ShopifyInventoryLevel.reserved
ShopifyInventoryLevel.damaged
ShopifyInventoryLevel.safety_stock
ShopifyInventoryLevel.quality_control
We didn't surface all new additional fields that have been added by Shopify in these versions. If you have fields you would like to see added, please open an issue or PR.
Documentation
Related Issues
Fixed FRB-1687