-
Notifications
You must be signed in to change notification settings - Fork 28
Introduced cobra commands. #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. The root command works exactly like before. I.e. it watches the endpoint objects and kicks the dependant pods in CrashloopBackoff. 2. The probe sub-command probes kube-apiservers using internal and external IP kubeconfigs and scales the dependant scale subresources up and down. Both the root command and the probe sub-command support managing a single namespace as well as all namespaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks nice. I have provided some minor comments. PTAL Thanks :)
@georgekuruvillak Thanks for the review comments. I have tried to address all of them. Can you PTAL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
I.e. it watches the endpoint objects and kicks the
dependant pods in
CrashloopBackoff
.using internal and external IP kubeconfigs and
scales the dependant scale subresources up and down.
Both the root command and the probe sub-command support
managing a single namespace as well as all namespaces.
Which issue(s) this PR fixes:
Partially Fixes #1447@gardener. Needs to be integrated via #1641@gardener.
Special notes for your reviewer:
I have moved the repo from dep to go modules. Also, I have removed any references to the
k8s.io/kubernetes
package which is not recommended.Release note: