Skip to content

Introduced cobra commands. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Conversation

amshuman-kr
Copy link
Collaborator

@amshuman-kr amshuman-kr commented Nov 21, 2019

What this PR does / why we need it:

  1. The root command works exactly like before.
    I.e. it watches the endpoint objects and kicks the
    dependant pods in CrashloopBackoff.
  2. The probe sub-command probes kube-apiservers
    using internal and external IP kubeconfigs and
    scales the dependant scale subresources up and down.

Both the root command and the probe sub-command support
managing a single namespace as well as all namespaces.

Which issue(s) this PR fixes:
Partially Fixes #1447@gardener. Needs to be integrated via #1641@gardener.

Special notes for your reviewer:
I have moved the repo from dep to go modules. Also, I have removed any references to the k8s.io/kubernetes package which is not recommended.

Release note:

Introduced cobra commands.
1. The root command works exactly like before.
I.e. it watches the endpoint objects and kicks the
dependant pods in CrashloopBackoff.
2. The probe sub-command probes kube-apiservers
using internal and external IP kubeconfigs and
scales the dependant scale subresources up and down.

Both the root command and the probe sub-command support
managing a single namespace as well as all namespaces.

1. The root command works exactly like before.
I.e. it watches the endpoint objects and kicks the
dependant pods in CrashloopBackoff.
2. The probe sub-command probes kube-apiservers
using internal and external IP kubeconfigs and
scales the dependant scale subresources up and down.

Both the root command and the probe sub-command support
managing a single namespace as well as all namespaces.
@amshuman-kr
Copy link
Collaborator Author

cc @georgekuruvillak @rfranzke

Copy link
Contributor

@georgekuruvillak georgekuruvillak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks nice. I have provided some minor comments. PTAL Thanks :)

@amshuman-kr
Copy link
Collaborator Author

@georgekuruvillak Thanks for the review comments. I have tried to address all of them. Can you PTAL?

Copy link
Contributor

@georgekuruvillak georgekuruvillak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgekuruvillak georgekuruvillak merged commit 90398a3 into gardener:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimise disruption to workload in case of kube-apiserver loadbalancer issues
5 participants