Introduced cobra commands. #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The root command works exactly like before. I.e. it watches the endpoint objects and kicks the dependant pods in CrashloopBackoff. 2. The probe sub-command probes kube-apiservers using internal and external IP kubeconfigs and scales the dependant scale subresources up and down. Both the root command and the probe sub-command support managing a single namespace as well as all namespaces.
georgekuruvillak
suggested changes
Nov 29, 2019
|
@georgekuruvillak Thanks for the review comments. I have tried to address all of them. Can you PTAL? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I.e. it watches the endpoint objects and kicks the
dependant pods in
CrashloopBackoff.using internal and external IP kubeconfigs and
scales the dependant scale subresources up and down.
Both the root command and the probe sub-command support
managing a single namespace as well as all namespaces.
Which issue(s) this PR fixes:
Partially Fixes #1447@gardener. Needs to be integrated via #1641@gardener.
Special notes for your reviewer:
I have moved the repo from dep to go modules. Also, I have removed any references to the
k8s.io/kubernetespackage which is not recommended.Release note: