Skip to content

export testresults as inlined ocm-resource #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

heldkat
Copy link
Contributor

@heldkat heldkat commented Jul 24, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

export testresults as inlined ocm-resource

@gardener-prow gardener-prow bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jul 24, 2025
@gardener-prow gardener-prow bot requested review from ashwani2k and unmarshall July 24, 2025 07:59
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2025
Copy link
Contributor

@ashwani2k ashwani2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heldkat for the changes.
I'm guessing these changes are generic and already incorporated elsewhere, so looks fine to me.

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
Copy link

gardener-prow bot commented Jul 28, 2025

LGTM label has been added.

Git tree hash: f4bce7acd2f9be32c29aba7740deec869e6584e9

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2025
@ashwani2k
Copy link
Contributor

/approve

Copy link

gardener-prow bot commented Jul 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwani2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashwani2k ashwani2k added the kind/task General task label Jul 28, 2025
@gardener-prow gardener-prow bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jul 28, 2025
@heldkat
Copy link
Contributor Author

heldkat commented Jul 28, 2025

@ashwani2k any idea why the merging is blocked?

@ashwani2k
Copy link
Contributor

I'm guessing moving to GitHub Actions might have changed something in the merge process. Checking on it.

@oliver-goetz
Copy link
Member

This PR needs to be merged manually. It modifies a Github workflow. Prow runs as a Github App. Github Apps are not allowed to change Github workflows by design, so it cannot merge this PR.

@ashwani2k ashwani2k merged commit 2ad5ab8 into gardener:master Jul 29, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/task General task lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants