Hide retry button as viewer #2489
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: klocke-io <[email protected]>
klocke-io
requested review from
grolu,
holgerkoser and
petersutter
as code owners
klocke-io
changed the title
gardener-robot
added
the
size/xs
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
grolu
approved these changes
Jun 13, 2025
petersutter
reviewed
Jun 13, 2025
| const canRetry = computed(() => { | ||
| if (!canPatchShoots.value) return // No permission to patch shoots |
There was a problem hiding this comment.
the comment is unnecessary, also we always add brackets (should have a linter for it). I also returned false to make it more explicit
Suggested change
| if (!canPatchShoots.value) return // No permission to patch shoots | |
| if (!canPatchShoots.value) { | |
| return false | |
| } |
|
@holgerkoser You have pull request review open invite, please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Retry button was visible as viewer
Which issue(s) this PR fixes:
Fixes #2477
Special notes for your reviewer:
Release note: