data_manager_manual: cast SelectToolParameter to string #2634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oolParameterWrapper while dict keys are strings)
and add explain why the cast is necessary.
|
With this fix you should only run into galaxyproject/galaxy#8792 if you create a new data table (which we should fix as well of course) |
mvdbeek
approved these changes
Oct 15, 2019
mvdbeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR CONTRIBUTOR:
I found some errors while testing biomaj2galaxy with Galaxy 19.05. So this PR fixes part of the problem: the DM code is getting a galaxy.tools.wrappers.SelectToolParameterWrapper while dict keys are strings
I'm preparing a PR for Galaxy too to fix another part of the problem