Allow uploading to collections. #3696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note: to test this you need to rebuild client as this PR does not include the built scripts and css. (might be an oversight @jmchilton ?) |
|
@martenson It is intentional - rebuilding the client makes rebasing difficult - but you are correct I should have pointed this out. |
jmchilton
force-pushed
the
upload_collection
branch
2 times, most recently
from
7e9496c to
7d438e4
Compare
jmchilton
force-pushed
the
upload_collection
branch
2 times, most recently
from
6bfc2b8 to
0d6f076
Compare
jmchilton
changed the title
jmchilton
force-pushed
the
upload_collection
branch
from
0d6f076 to
b524a88
Compare
- New upload tab for "Collections". - This has a new option to select "Collection Type" in footer. - Collection upload geared toward homogeneous datasets - must specify genome and file format for all files. - New button "Build" after all individual datasets have finished their upload to the server. - Clicking "Build" launches the appropriate collection builder for selected collection type. - By default, uploading a collection hides the original uploaded datasets (can be unchecked). Implement tests for all uploaded collection types.
jmchilton
force-pushed
the
upload_collection
branch
from
b524a88 to
606c329
Compare
Closed
|
thanks @jmchilton - big step forward in improving collection user experience |
|
Yay - thanks for the detailed review and merge @martenson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on collection builder enhancements from open PR #3806.
This adds a new upload tab for "Collections".
This includes Selenium web tests for all three collection types as well as for hiding/not hiding the original datasets and the file extension selector.