Skip to content

[16.07] curated release notes for 16.07 #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 24, 2016

Conversation

martenson
Copy link
Member

@galaxyproject/core please comment, commit or PR against martenson/galaxy

TODO: choose second highlight

@martenson martenson added this to the 16.07 milestone Aug 19, 2016
New installs
.. code-block:: shell

% git clone -b release_16.07 https://github.com/galaxyproject/galaxy.git
Copy link
Member Author

@martenson martenson Aug 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note this has been switched to release_16.07 from master

@bgruening
Copy link
Member

I think DTD, Azure blob objectstore or the Kubernetes job runner are significant and awesome new features.

@jmchilton
Copy link
Member

+1 to DTD - it seems the most broadly applicable and stable thing to report on.

Optionally update to latest stable release
.. code-block:: shell

% git checkout master && pull --ff-only origin master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

Update to latest stable release
  .. code-block:: shell

      % git checkout release_16.07 && git pull --ff-only origin release_16.07

Note that a git was missing after &&

@martenson
Copy link
Member Author

highlight added, git commands updated

@jmchilton
Copy link
Member

You added more categories (API and collections?) - we used to do things that way but I really like the clean flatter list - the categories just seem very arbitrary.

@martenson
Copy link
Member Author

@jmchilton I ordered the PRs based on subjective importance for the highlighted group. then I order them by type in this group - and they ended up in these groups, so I gave them headings 😢

@afgane
Copy link
Contributor

afgane commented Aug 22, 2016

I feel that the highlighted items should have a wiki page with usage docs created for them rather than just pointing to a very dev-centric PRs. For example, reading "Install via conda, PR #2554" means very little to someone not involved with the development of that particular feature.

@martenson
Copy link
Member Author

martenson commented Aug 22, 2016

@afgane for Conda we have accompanying 7 page document we will add. For others there should have been documentation but...nobody writes it we do not write it much.

@jmchilton
Copy link
Member

@martenson I'd just eliminate the headings - I like them being ordered together.

@martenson I agree with @afgane's comment - I have a commit in progress to give some of these items more user-centric names. It is a good reminder to everyone who contributes to Galaxy to do this when naming PRs though so this doesn't need to be done at this stage. Hope this is okay @martenson - I can PR it instead of direct commit if you wish.

@afgane
Copy link
Contributor

afgane commented Aug 22, 2016

For others there should have been documentation but...nobody writes it we do not write it much.

My point exactly - it feels like the docs for the highlighted items at least should be a requirement of the PR just like passing the tests is.

@martenson
Copy link
Member Author

martenson commented Aug 22, 2016

@afgane These are community PRs, we shouldn't enforce community contributors to write extensive documentation. We should probably do it ourselves instead if it is not provided.

There is decent documentation for the DTD, I will dig it up and make it coherent on wiki somewhere.

Chat is an admin (and experimental) feature. @erasche @bgruening @anuprulez could you do a small writeup of how to turn it on and use it please?

@martenson
Copy link
Member Author

@jmchilton direct commit is fine; I am not sold on dropping the headings though

@martenson martenson changed the title [16.07] initial curated release notes for 16.07 [16.07] curated release notes for 16.07 Aug 22, 2016
@afgane
Copy link
Contributor

afgane commented Aug 22, 2016

I'm of the opinion that if someone is going to take the time to develop a feature and PR it so that it gets included in the main distribution, they would then like to see the feature used. Requiring the docs might be a strong word but what about strongly encouraging it at least? They way I see it, if a feature is not documented, it might as well not exist.

@martenson
Copy link
Member Author

@afgane The definition of 'documented' is variable. There is often good information about how to use it in the PR itself, or in sample files. I agree that highlighted features should have coherent docs outside of PR and am working towards that for 16.07.

@jmchilton
Copy link
Member

I'd encourage discussions about changes in policy related to documentation of contributions to be filed as a modification to the contributing document or in an issue - this doesn't seem the appropriate forum.

* HTCondor Docker Integration
(thanks to `@bgruening <https://github.com/bgruening>`__.)
`Pull Request 2278`_
* Impelement a Kubernetes job runner
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Impelement/Implement/

* Add the Mothur datatypes
(thanks to `@shiltemann <https://github.com/shiltemann>`__.)
`Pull Request 2038`_, `Pull Request 2429`_
* Add the dynamic tool destination tool to Galaxy for defining finer grained
Copy link
Member Author

@martenson martenson Aug 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved these following 3 to the end of the highlighted section since they are release highlights already

@@ -79,53 +80,56 @@ Enhancements

* Install Conda at startup; enable conda_auto_init in sample conf
`Pull Request 2759`_
* Add filter_failed_datasets_from_collection.py script
* Add ``filter_failed_datasets_from_collection.py`` script ot ``scripts/``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ot/to/

`Pull Request 2335`_
* History/Sharable model user sharing API
* Implement and API for managing history/sharable model user sharing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/and/an/ I guess

@martenson
Copy link
Member Author

martenson commented Aug 22, 2016

I have reworded the Conda highlight to announce it as Beta and opt-in
#2826
#2834

@martenson
Copy link
Member Author

martenson commented Aug 23, 2016

this is waiting for #2844 and needs to be modified afterwards

@martenson
Copy link
Member Author

This is now ready to be merged.

@jmchilton jmchilton merged commit df47bd2 into galaxyproject:release_16.07 Aug 24, 2016
@martenson martenson deleted the 16.07_release_notes branch August 24, 2016 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants