-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[16.07] curated release notes for 16.07 #2821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.07] curated release notes for 16.07 #2821
Conversation
New installs | ||
.. code-block:: shell | ||
|
||
% git clone -b release_16.07 https://github.com/galaxyproject/galaxy.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note this has been switched to release_16.07
from master
I think DTD, Azure blob objectstore or the Kubernetes job runner are significant and awesome new features. |
+1 to DTD - it seems the most broadly applicable and stable thing to report on. |
Optionally update to latest stable release | ||
.. code-block:: shell | ||
|
||
% git checkout master && pull --ff-only origin master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be:
Update to latest stable release
.. code-block:: shell
% git checkout release_16.07 && git pull --ff-only origin release_16.07
Note that a git
was missing after &&
highlight added, git commands updated |
You added more categories (API and collections?) - we used to do things that way but I really like the clean flatter list - the categories just seem very arbitrary. |
@jmchilton I ordered the PRs based on subjective importance for the |
I feel that the highlighted items should have a wiki page with usage docs created for them rather than just pointing to a very dev-centric PRs. For example, reading "Install via conda, PR #2554" means very little to someone not involved with the development of that particular feature. |
@afgane for Conda we have accompanying 7 page document we will add. For others there should have been documentation but... |
@martenson I'd just eliminate the headings - I like them being ordered together. @martenson I agree with @afgane's comment - I have a commit in progress to give some of these items more user-centric names. It is a good reminder to everyone who contributes to Galaxy to do this when naming PRs though so this doesn't need to be done at this stage. Hope this is okay @martenson - I can PR it instead of direct commit if you wish. |
My point exactly - it feels like the docs for the highlighted items at least should be a requirement of the PR just like passing the tests is. |
@afgane These are community PRs, we shouldn't enforce community contributors to write extensive documentation. We should probably do it ourselves instead if it is not provided. There is decent documentation for the DTD, I will dig it up and make it coherent on wiki somewhere. Chat is an admin (and experimental) feature. @erasche @bgruening @anuprulez could you do a small writeup of how to turn it on and use it please? |
@jmchilton direct commit is fine; I am not sold on dropping the headings though |
I'm of the opinion that if someone is going to take the time to develop a feature and PR it so that it gets included in the main distribution, they would then like to see the feature used. Requiring the docs might be a strong word but what about strongly encouraging it at least? They way I see it, if a feature is not documented, it might as well not exist. |
@afgane The definition of 'documented' is variable. There is often good information about how to use it in the PR itself, or in sample files. I agree that highlighted features should have coherent docs outside of PR and am working towards that for 16.07. |
I'd encourage discussions about changes in policy related to documentation of contributions to be filed as a modification to the contributing document or in an issue - this doesn't seem the appropriate forum. |
* HTCondor Docker Integration | ||
(thanks to `@bgruening <https://github.com/bgruening>`__.) | ||
`Pull Request 2278`_ | ||
* Impelement a Kubernetes job runner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Impelement/Implement/
* Add the Mothur datatypes | ||
(thanks to `@shiltemann <https://github.com/shiltemann>`__.) | ||
`Pull Request 2038`_, `Pull Request 2429`_ | ||
* Add the dynamic tool destination tool to Galaxy for defining finer grained |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved these following 3 to the end of the highlighted section since they are release highlights already
@@ -79,53 +80,56 @@ Enhancements | |||
|
|||
* Install Conda at startup; enable conda_auto_init in sample conf | |||
`Pull Request 2759`_ | |||
* Add filter_failed_datasets_from_collection.py script | |||
* Add ``filter_failed_datasets_from_collection.py`` script ot ``scripts/`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/ot/to/
`Pull Request 2335`_ | ||
* History/Sharable model user sharing API | ||
* Implement and API for managing history/sharable model user sharing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/and/an/ I guess
this is waiting for #2844 and needs to be modified afterwards |
This is now ready to be merged. |
@galaxyproject/core please comment, commit or PR against
martenson/galaxy
TODO: choose second highlight