Skip to content

[25.0] Fix pagination state in FilesDialog #20452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

davelopez
Copy link
Contributor

Not quite related to #20448, but it reminded me that we have a temporal fix that we forgot to PR here regarding FilesDialog.

This fixes navigation when there are multiple pages and we drill down into a folder. When going "back", the current behaviour just lands you on the first page always. With this change, we will land on the last page where we drilled down into a folder.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Open the remote files dialog
    2. Select a plugin that contains many pages, like "zenodo"
    3. Navigate to any page
    4. Go inside one of the folders
    5. Go back
    6. Observe that you are now on the same page before entering the folder

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Remember last page when navigating back
@github-actions github-actions bot added this to the 25.1 milestone Jun 13, 2025
@mvdbeek mvdbeek merged commit 0167911 into galaxyproject:release_25.0 Jun 13, 2025
27 of 29 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Jun 13, 2025

Thank you @davelopez!

@davelopez davelopez deleted the 25.0_fix_pagination_state_in_files_dialog branch June 13, 2025 15:01
@ahmedhamidawan ahmedhamidawan modified the milestones: 25.1, 25.0 Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants