Skip to content

[25.0] Set GALAXY_CONFIG_FILE env var if starting handler with -c #20449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 13, 2025

I think this should fix #20307
I had previously already tried to fix this via #18819, but this seems to be back in 25.0. It's a bit of a brute-force method, but it looks like once we build the celery_app that's the one the tasks get bound to. We probably could change the decorator to delay celery_app construction until the first use, this should also always work.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.1 milestone Jun 13, 2025
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this! 🤞

@jdavcs jdavcs changed the title [25.0] Set GALAXY_CONFIG_FILE env var if staring handler with -c [25.0] Set GALAXY_CONFIG_FILE env var if starting handler with -c Jun 13, 2025
@mvdbeek mvdbeek merged commit 47bfa87 into galaxyproject:release_25.0 Jun 13, 2025
55 of 57 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants