[25.0] DatasetView and Card Polish #20342
Conversation
github-actions
bot
changed the title
|
Thanks @dannon for working on this. Can we maybe postponing the changes to the Dataset Card? Imho it's way too late to change this now, and we should bring back the |
|
@bgruening I'm disappointed - the whole point of streamlining is to improve UX so that it's intuitive for users without having to consult docs and know to look for the tiny icon you only see when the card expands, not preserve cluttered interfaces because they're documented. But I'm having whiplash here going back and forth and I can't keep revisiting this for the release. I'll punt on the card icon changes and leave all the icons in for the release, and will remove them in dev. |
|
Does the WIP label still apply @dannon ? |
|
Deployed it to test and really like it, especially that we prevent the download via the preview. Just one thing that is maybe inconsistent is the visualize button on the dataset card goes directly to the visualization component instead of the tabbed view. I think I'd find it more consistent to show this via the tabbed view in the center panel ? I think that would also have a bit of an educational effect, as in users discovering and remembering that the important stuff is in the center panel now |
| * Get details about a specific datatype | ||
| */ | ||
| export async function fetchDatatypeDetails(extension: string) { | ||
| try { |
There was a problem hiding this comment.
This is a fastapi route, any reason not to use the typed fetcher ?
Yeah, these should all be using the tabbed view, oversight from having to hack the buttons back in -- I'll fix this. |
dannon
changed the title
dannon
force-pushed
the
tab-icons
branch
3 times, most recently
from
81cc383 to
b855b36
Compare
|
Just to note it here, there's also a bug where for preferred datatypes we aren't waiting to see that before rendering, currently. So the first time you view, you might get a raw display, then the viz on re-display. |
- Remove misc_info field that is overly often filled with garbage - Add file size display with human-readable formatting - Improve styling with proper spacing and muted labels
When a dataset has a preferred visualization, the Preview tab shows the visualization. This adds a Raw tab to allow users to view the raw data display alongside the visualization.
Certain file types (TIFF, PDF, office documents, archives) trigger automatic downloads when loaded in an iframe. This change detects these file types and shows a download prompt instead of attempting to display them inline.
…on so the client can account for direct download vs preview, etc.
- Add Raw tab to DatasetView when datasets have automatic visualizations, allowing users to view raw data alongside visualizations - Prevent file types that trigger automatic downloads (TIFF, PDF, etc.) from loading in iframes, showing download prompt instead
…know if we are preview/viz/raw/etc.
Prevent line breaks in hid and dataset state while allowing name to wrap. Consolidate datatype and dataset loading states into single computed property.
Smoothing out user interactions with the new streamlined view.
xref #20301
Adjusted header:
Nicer formatting, dropped 'info', which folks agreed was usually cluttered with unhelpful stderr.
We keep 'blurb'.
For the card options, eye and error are dropped and we're going with a new icon.
Here's faExpand:
And here's ScanEye:
I'm also going to mock up a quick composite of faEye and faExpand (which will be a lot like ScanEye, but with fa styles) in a sec.
How to test the changes?
(Select all options that apply)
License