Skip to content

[25.0] Enable retrieving contents from extra file paths when request contains leading / #20336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 22, 2025

by stripping all leading / in filename.

I don't think there's a legitimate reason that we should treat this as an absolute path marker. Addresses @luke-c-sargent's comment in goeckslab/tools-mti#99 (comment)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

by stripping all leading `/` in filename.

I don't think there's a legitimate reason that we should treat this as
an absolute path marker. Addresses @luke-c-sargent's comment in
goeckslab/tools-mti#99 (comment)
@martenson martenson merged commit 0ed8bf5 into galaxyproject:release_25.0 May 22, 2025
51 of 55 checks passed
@martenson martenson deleted the strip_leading_slash branch May 22, 2025 18:49
@martenson martenson modified the milestones: 25.1, 25.0 May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants