Skip to content

Bug fix - allow file drops into PasteData widget. #20232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

jmchilton
Copy link
Member

Fixes #20231.

I still think it was hard to find / indirect - I wish DragAndDropModal.vue had a prominent comment somewhere to point at this but I couldn't a natural place to document it. Maybe in Analysis.vue right before the DragAndDropModal component appears? At any rate - that would be an enhancement - this is the bug fix.

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Go to localhost:8081/rules , pick either option on the first step of the wizard, pick "Paste Data" on the second step, drop a text file into the resulting textbox.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot changed the title [25.0] Bug fix - allow file drops into PasteData widget. Bug fix - allow file drops into PasteData widget. May 15, 2025
Copy link
Member

@ElectronicBlueberry ElectronicBlueberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish DragAndDropModal.vue had a prominent comment somewhere to point at this

I think the very top of DragAndDropModal.vue would be the best place to put this. If some component is behaving in a way I don't expect, the component itself is the first place I would usually check.

@jmchilton
Copy link
Member Author

I think the very top of DragAndDropModal.vue would be the best place to put this. If some component is behaving in a way I don't expect, the component itself is the first place I would usually check.

In the abstract I agree but I'm not sure I love it. I added it anyway though with the rebase.

@jmchilton jmchilton marked this pull request as ready for review May 15, 2025 18:43
@github-actions github-actions bot added this to the 25.1 milestone May 15, 2025
@ElectronicBlueberry ElectronicBlueberry merged commit 3d6dd63 into galaxyproject:dev May 15, 2025
31 checks passed
@jmchilton
Copy link
Member Author

Thanks for the PR review and merge!

@ahmedhamidawan ahmedhamidawan modified the milestones: 25.1, 25.0 Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag and Drop in the Main Frame
3 participants