Dataset View Component

[dannon]

Want to iterate on this and fix any bugs before the release. Some preview displays can take a moment, so I need to add a loading indicator there. Also needs tweaks to header handling in some of the subcomponents. Includes unit tests, but will need selenium updates and additions.

I'm still working out the details of making it possible to have 'preferred' display applications for particular datatypes. These will likely be both admin and user specified -- like, when someone wants to view an h5, we don't display the binary view, we use hd5web by default instead. These will, of course, be opinionated so maybe we should focus on binary or otherwise not-useful-primary-display types first. Second PR coming.

firefox_dKeuMA3eO9.mp4

This needs several tests updated but could use feedback on the basic functionality.

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[guerler]

This is a great and much-needed feature—thank you for implementing it! I noticed a few issues:

• The re-run button is visible for uploaded items.
• Clicking the re-run button leads to a blank page.
• I suggest hiding the dataset info panel, as it leaves a large empty space to its right. Perhaps replace it with a compact one-line summary, possibly using icons—similar to how we display history size and the number of active/deleted datasets in the history view.
• Scrolling does not work within the Details, Visualizations, or Edit tabs.
• The headers for Dataset Information and Edit Dataset Attributes should be aligned.
• Align padding, background color and separator line to existing similar tabs:
  

[guerler]

We can fix this later but the dataset info is flickering when switching tabs, I also think that it's not placed well there. We could just add it to the Dataset information panel at the top, that would make more sense imo. Maybe we could at least set the default to collapsed.

[dannon]

@guerler Yep, that happened when I tweaked the routing, it's on my list.

[guerler]

This is a useful feature. Some remaining issues may need to be revisited, like e.g. moving the dataset info to the Dataset Information panel, but we can address those during the freeze period. Thank you for adding it.

[mvdbeek]

More bikeshedding, maybe move visualize into 2nd position

[davelopez]

Even more bikeshedding, how about controlling the destination tab using query parameters? Maybe it is already there, I didn't check yet :P

[dannon]

I'm going to shift rerun back to the original position, which will fix it -- the problem was available details that we just don't have at the top (unexpanded) level of a dataset and we don't want to have to fetch for everything.

@mvdbeek I can move that back.

@davelopez It already does, just not as a query argument but the route itself!