Skip to content

Additional type hints for toolbox.get_tool / toolbox.has_tool #20150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

Additional type hints for toolbox.get_tool / toolbox.has_tool #20150

merged 2 commits into from
May 5, 2025

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 5, 2025

And related hints around workflow runs.

Broken out of #19434

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek added the kind/refactoring cleanup or refactoring of existing code, no functional changes label May 5, 2025
@github-actions github-actions bot added this to the 25.0 milestone May 5, 2025
@mvdbeek mvdbeek force-pushed the add_workflow_dict_run_typing branch from da5a9c2 to 4b8b778 Compare May 5, 2025 13:16
jmchilton
jmchilton approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@mvdbeek mvdbeek merged commit 37a26a6 into galaxyproject:dev May 5, 2025
50 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

Assignees
No one assigned
Labels
area/API area/jobs area/tool-framework area/util area/workflows kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mvdbeek @jmchilton