Skip to content

Add activity panel width to local storage #20072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Apr 22, 2025

Fixes #20067

Adds activity bar side panel and history panel width to local storage.

remember_flex_panel_width.mp4

Questions 🤔 :

  • Should we make it different widths for different panels? (e.g.: remember the tool panel width and invocation panel width separately, instead of same widths for all activity panels right now) Nooooo 👎
  • Should we also put the history panel collapse state in local storage?

✅ Otherwise, good to go!

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Change activity bar side panel (tool panel/invocations panel etc.) width via the drag handle
    2. Close and open the panels, and switch between them to note that the width is retained
    3. Refresh the page to note that the width is retained (via local storage)
    4. Do the same for the history panel

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ahmedhamidawan ahmedhamidawan marked this pull request as ready for review April 22, 2025 17:37
@github-actions github-actions bot added this to the 25.0 milestone Apr 22, 2025
@ElectronicBlueberry
Copy link
Member

Should we make it different widths for different panels? (e.g.: remember the tool panel width and invocation panel width separately, instead of same widths for all activity panels right now)

No. That seems very unintuitive to use and work with

@mvdbeek mvdbeek merged commit 35dae99 into galaxyproject:dev Apr 29, 2025
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side panels no longer remember size
3 participants