Skip to content

Update breadcrumb item 'to' type for better routing support #20065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Apr 22, 2025

Change the breadcrumb item's to property type from string to typed RawLocation from vue-router, allowing for named locations as expected by RouterLink/vue-router.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Replaces only string routes with typed `RawLocation` objects in breadcrumb item to accept named locations as RouterLink/vue-router expected.
Updates related components to reflect this change.
@github-actions github-actions bot added this to the 25.0 milestone Apr 22, 2025
@mvdbeek mvdbeek merged commit 4c1b88d into galaxyproject:dev Apr 23, 2025
33 of 34 checks passed
@itisAliRH itisAliRH deleted the breadcrump-to-type-improve branch April 23, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants