-
Notifications
You must be signed in to change notification settings - Fork 1.1k
GLink implementation #20063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ahmedhamidawan
merged 18 commits into
galaxyproject:dev
from
ElectronicBlueberry:g-link-implementation
May 7, 2025
Merged
GLink implementation #20063
ahmedhamidawan
merged 18 commits into
galaxyproject:dev
from
ElectronicBlueberry:g-link-implementation
May 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c830dd
to
7960276
Compare
7960276
to
98be732
Compare
4 tasks
fix overstyling
add bootstrap overrides
add thin variant
58c2da4
to
5573302
Compare
ahmedhamidawan
approved these changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looking forward to using these!
I think failing tests like:
FAILED lib/galaxy_test/selenium/test_workflow_run.py::TestWorkflowRun::test_workflow_run_button_disabled_when_required_input_missing - selenium.common.exceptions.TimeoutException: Message: Timeout waiting on CSS selector [#run-workflow.disabled] to become present.
are being resolved separately.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a GLink component. Reduces code duplication between this and GButton.
GLink looks like a link, but automatically switches to the correct html tag depending on the props provided, just like GButton.
How to test the changes?
(Select all options that apply)
License