Skip to content

GLink implementation #20063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ElectronicBlueberry
Copy link
Member

Adds a GLink component. Reduces code duplication between this and GButton.

GLink looks like a link, but automatically switches to the correct html tag depending on the props provided, just like GButton.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ElectronicBlueberry ElectronicBlueberry marked this pull request as ready for review April 29, 2025 14:05
@github-actions github-actions bot added this to the 25.0 milestone Apr 29, 2025
@ElectronicBlueberry ElectronicBlueberry marked this pull request as draft April 29, 2025 14:53
@ElectronicBlueberry ElectronicBlueberry mentioned this pull request May 6, 2025
4 tasks
@ElectronicBlueberry ElectronicBlueberry marked this pull request as ready for review May 6, 2025 13:51
@ahmedhamidawan ahmedhamidawan self-requested a review May 6, 2025 14:38
@ahmedhamidawan
Copy link
Member

Works great and looks really nice!

One thing, the GLink doesn't look visibly different when it is disabled. Maybe that's fine? Though i think a minor change with adding the g-disabled class and setting it as:

    &.g-disabled {
        cursor: not-allowed;
    }

could make it more obvious?:

firefox_fREaoLCJSO

@ElectronicBlueberry
Copy link
Member Author

How about this?

    &.g-disabled {
        text-decoration: underline;
        color: var(--color-grey-500) !important;
        cursor: default;
    }

image

Copy link
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looking forward to using these!

I think failing tests like:

FAILED lib/galaxy_test/selenium/test_workflow_run.py::TestWorkflowRun::test_workflow_run_button_disabled_when_required_input_missing - selenium.common.exceptions.TimeoutException: Message: Timeout waiting on CSS selector [#run-workflow.disabled] to become present.

are being resolved separately.

@ahmedhamidawan ahmedhamidawan merged commit f4f1c33 into galaxyproject:dev May 7, 2025
26 of 30 checks passed

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants