Skip to content

Remove hgv_sift from tool_conf.xml.sample #19972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Apr 9, 2025

This depends on data table sift_db which likely does not exist (and does not in a default install), so even brand new installs start up with a traceback in the log:

galaxy.tool_util.toolbox.base ERROR 2025-04-09 15:28:36,051 [pN:main,p:1272727,tN:MainThread] Error reading tool from path: phenotype_association/sift.xml
Traceback (most recent call last):
  File "/home/nate/work/galaxy/lib/galaxy/tool_util/toolbox/base.py", line 892, in _load_tool_tag_set
    tool = self.load_tool(concrete_path, use_cached=False, tool_cache_data_dir=tool_cache_data_dir)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/nate/work/galaxy/lib/galaxy/tool_util/toolbox/base.py", line 1125, in load_tool
    tool = self.create_tool(
           ^^^^^^^^^^^^^^^^^
  File "/home/nate/work/galaxy/lib/galaxy/tools/__init__.py", line 599, in create_tool
    return self._create_tool_from_source(tool_source, config_file=config_file, **kwds)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/nate/work/galaxy/lib/galaxy/tools/__init__.py", line 615, in _create_tool_from_source
    return create_tool_from_source(self.app, tool_source, **kwds)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/nate/work/galaxy/lib/galaxy/tools/__init__.py", line 411, in create_tool_from_source
    tool = ToolClass(config_file, tool_source, app, **kwds)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/nate/work/galaxy/lib/galaxy/tools/__init__.py", line 1053, in __init__
    raise e
  File "/home/nate/work/galaxy/lib/galaxy/tools/__init__.py", line 1050, in __init__
    self.parse(tool_source, guid=guid, dynamic=dynamic)
  File "/home/nate/work/galaxy/lib/galaxy/tools/__init__.py", line 1372, in parse
    self.parse_inputs(self.tool_source)
  File "/home/nate/work/galaxy/lib/galaxy/tools/__init__.py", line 1658, in parse_inputs
    inputs = self.parse_input_elem(page_source, enctypes)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/nate/work/galaxy/lib/galaxy/tools/__init__.py", line 1845, in parse_input_elem
    param = self.parse_param_elem(input_source, enctypes, context)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/nate/work/galaxy/lib/galaxy/tools/__init__.py", line 1858, in parse_param_elem
    param = ToolParameter.build(self, input_source)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/nate/work/galaxy/lib/galaxy/tools/parameters/basic.py", line 360, in build
    return parameter_types[param_type](tool, input_source)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/nate/work/galaxy/lib/galaxy/tools/parameters/basic.py", line 2066, in __init__
    super().__init__(tool, input_source, trans)
  File "/home/nate/work/galaxy/lib/galaxy/tools/parameters/basic.py", line 1855, in __init__
    super().__init__(tool, input_source)
  File "/home/nate/work/galaxy/lib/galaxy/tools/parameters/basic.py", line 211, in __init__
    self.validators = validation.to_validators(tool.app if tool else None, input_source.parse_validators())
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/nate/work/galaxy/lib/galaxy/tools/parameters/validation.py", line 520, in to_validators
    validators.append(_to_validator(app, validator_model))
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/nate/work/galaxy/lib/galaxy/tools/parameters/validation.py", line 530, in _to_validator
    tool_data_table = app.tool_data_tables[table_name]
                      ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/home/nate/work/galaxy/lib/galaxy/tool_util/data/__init__.py", line 947, in __getitem__
    return self.data_tables.__getitem__(key)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'sift_db'

@github-actions github-actions bot added this to the 25.0 milestone Apr 9, 2025
@mvdbeek mvdbeek merged commit ea221fe into galaxyproject:dev Apr 10, 2025
50 of 54 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Apr 10, 2025

Thank you!

Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants